feat(web): add static file serving via process_request hook#109
Merged
kimit0310 merged 2 commits intoApr 13, 2026
Conversation
…ixing broadcaster start target.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #109 +/- ##
======================================
Coverage ? 90.46%
======================================
Files ? 8
Lines ? 304
Branches ? 0
======================================
Hits ? 275
Misses ? 29
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Asanto32
reviewed
Apr 1, 2026
Collaborator
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Some minor comments + import issues
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds static file serving to the WebSocket server so the upcoming SvelteKit frontend can be served from the same port.
The websockets library has a
process_requesthook that fires before every WebSocket handshake. We use it to check whether the incoming request is a regular HTTP request (noUpgradeheader) and if so, serve the file fromweb/static/. WebSocket connections pass through tows_handleras before.Path traversal is handled by resolving the requested path and checking it stays inside
STATIC_DIRviaPath.relative_to(). Percent encoded characters are decoded first so tricks like%2e%2edon't bypass the check.New helper functions
_is_websocket_upgrade,_serve_static_file,_is_within_static_dir,_error_responseadded.